Conversation
…into feature/ILEX-83
…into feature/ILEX-83
ddelpiano
requested changes
Apr 7, 2025
index.html
Outdated
| <div id="root"></div> | ||
| <script type="module" src="/src/main.jsx"></script> | ||
| <script> const global = globalThis; </script> | ||
| <div id="orcidWidget" style="display: none;"></div> |
Member
There was a problem hiding this comment.
@Aiga115 could clean this up? we do not need the widget anymore. Thanks
src/App.jsx
Outdated
| }; | ||
|
|
||
| function App() { | ||
| const initialized = useRef(false); |
| ) => { | ||
| return customInstance<void>( | ||
| { | ||
| url: `https://uri.olympiangods.org/u/ops/user-login`, |
Member
There was a problem hiding this comment.
use the const variables instead of hardcoding the url and endpoints please, so that if later we need to change these we can change them from a single point.
Author
There was a problem hiding this comment.
@ddelpiano I changed the api to use constant variables but just a reminder that i am not using this function for signing in, th login function is in src/api/endpoints/apiService file
ddelpiano
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #ILEX-83
Problem: Connect the sign-in form to the ORCID and integrate user authentication in the application state
Solution:
Issue #ILEX-97
Issue #ILEX-96
Recording.2025-04-03.162001.mp4